This repository has been archived by the owner on Mar 5, 2018. It is now read-only.
Check current tag before re-rendering #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadhietala
force-pushed
the
its-like-svn
branch
from
18d104e
to
3876661
Compare
|
This is likely not correct. |
|
This is unnecessary because the only thing that should be scheduling rendering should also bump the current revision. If there are places that are scheduling a rerender without bumping the tag, we should discuss that because it's a violation of the current assumptions. |
|
Well there is still something going wrong. An idempotent set causes the everything to get re-rendered. |
|
I believe that is working as intended. The diffing happens on reads, not writes. The set would cause |
chadhietala
force-pushed
the
its-like-svn
branch
from
b94d405
to
c142970
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure what is going on with the tests here, but this is likely what needs to be done. Should close #50 and #43