Skip to content
This repository has been archived by the owner on Mar 5, 2018. It is now read-only.

@tracked doesn't play nice #45

Closed
chadhietala opened this issue Apr 9, 2017 · 3 comments
Closed

@tracked doesn't play nice #45

chadhietala opened this issue Apr 9, 2017 · 3 comments

Comments

@chadhietala
Copy link
Member

Based on glimmerjs/glimmer-application#53, glimmerjs/glimmer-application#50, and glimmerjs/glimmer-application#43 there is a weird interaction with @tracked and scheduling a re-render. I thought I could fix it in glimmerjs/glimmer-application#52, however @krisselden mentioned that we likely need to internalize the check for CURRENT in Glimmer VM it's self. You simply cannot have @tracked cause the re-render directly, and in stead you need to check to see if the transaction needs to start at all.

@habdelra
Copy link
Contributor

I ran into this as well, I've seen a bunch of manifestations of this problems in various forms. Here's my attempt at the very simplest means to reproduce it (there's a console log that logs each rerender cycle).

https://github.com/habdelra/glimmerjs-infinite-rerender

screen shot 2017-04-10 at 4 32 52 pm

@krisselden
Copy link

@chadhietala #52 is fine for now, just not when multiple apps are on one page, unless they don't share anything.

@rwjblue
Copy link
Member

rwjblue commented Mar 5, 2018

This repo has been merged with glimmerjs/glimmer.js (into a monorepo setup). I am not sure if this issue is still applicable, but if you could confirm it is still an ongoing concern and open it over there that would be very helpful.

Sorry for the noise, but thank you for your help!

@rwjblue rwjblue closed this as completed Mar 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants