Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate glimmer-engine dependency duplication. #1

Closed
dgeb opened this issue Jan 11, 2017 · 0 comments
Closed

Eliminate glimmer-engine dependency duplication. #1

dgeb opened this issue Jan 11, 2017 · 0 comments

Comments

@dgeb
Copy link
Member

dgeb commented Jan 11, 2017

Currently, glimmer-build requires that tests be run with an AMD loader. This approach was taken for expediency and has not been re-examined since these libs were created.

Originally, glimmer-di just had a dependency on glimmer-engine, which includes an AMD distribution. The glimmer-util package was created later and should supersede glimmer-engine, but glimmer-util does not include an AMD distribution. So glimmer-di maintains its glimmer-engine dev dependency only for testing. It's clear that this dependency duplication needs to be eliminated.

If we want to continue to run tests with AMD modules, glimmer-build could be tweaked to compile AMD from glimmer-util's source modules OR glimmer-util could simply export AMD with its distribution. Or perhaps we should re-examine the AMD testing approach altogether.

dgeb added a commit that referenced this issue Jan 28, 2017
Glimmer-engine dependency is no longer needed.

[Closes #1]
dgeb added a commit that referenced this issue Jan 28, 2017
Glimmer-engine dependency is no longer needed.

[Closes #1]
@dgeb dgeb closed this as completed in #16 Jan 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant