You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, glimmer-build requires that tests be run with an AMD loader. This approach was taken for expediency and has not been re-examined since these libs were created.
Originally, glimmer-di just had a dependency on glimmer-engine, which includes an AMD distribution. The glimmer-util package was created later and should supersede glimmer-engine, but glimmer-util does not include an AMD distribution. So glimmer-di maintains its glimmer-engine dev dependency only for testing. It's clear that this dependency duplication needs to be eliminated.
If we want to continue to run tests with AMD modules, glimmer-build could be tweaked to compile AMD from glimmer-util's source modules OR glimmer-util could simply export AMD with its distribution. Or perhaps we should re-examine the AMD testing approach altogether.
The text was updated successfully, but these errors were encountered:
Currently, glimmer-build requires that tests be run with an AMD loader. This approach was taken for expediency and has not been re-examined since these libs were created.
Originally,
glimmer-di
just had a dependency onglimmer-engine
, which includes an AMD distribution. Theglimmer-util
package was created later and should supersedeglimmer-engine
, butglimmer-util
does not include an AMD distribution. Soglimmer-di
maintains itsglimmer-engine
dev dependency only for testing. It's clear that this dependency duplication needs to be eliminated.If we want to continue to run tests with AMD modules,
glimmer-build
could be tweaked to compile AMD fromglimmer-util
's source modules ORglimmer-util
could simply export AMD with its distribution. Or perhaps we should re-examine the AMD testing approach altogether.The text was updated successfully, but these errors were encountered: