Merge pull request #857 from chiragpat/debug_fix

Fix debug issues reported in #846
glimmerjs · Oct 2, 2018 · 7b41a7b · 7b41a7b
2 parents 7f041fd + 73a3967
commit 7b41a7b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/packages/@glimmer/bundle-compiler/lib/debug-constants.ts b/packages/@glimmer/bundle-compiler/lib/debug-constants.ts
@@ -1,6 +1,10 @@
 import { WriteOnlyConstants } from '@glimmer/program';
 
 export default class DebugConstants extends WriteOnlyConstants {
+  getNumber(value: number): number {
+    return this.numbers[value];
+  }
+
   getString(value: number): string {
     return this.strings[value];
   }

diff --git a/packages/@glimmer/opcode-compiler/lib/debug.ts b/packages/@glimmer/opcode-compiler/lib/debug.ts
@@ -174,6 +174,7 @@ function decodePrimitive(primitive: number, constants: DebugConstants): Primitiv
           return undefined;
       }
     case PrimitiveType.NEGATIVE:
+    case PrimitiveType.BIG_NUM:
       return constants.getNumber(value);
     default:
       throw unreachable();

diff --git a/packages/@glimmer/vm/lib/-debug-strip.ts b/packages/@glimmer/vm/lib/-debug-strip.ts
@@ -427,7 +427,8 @@ OPCODE_METADATA(Op.BindEvalScope, {
 
 OPCODE_METADATA(Op.InvokeComponentLayout, {
   name: 'InvokeComponentLayout',
-  stackChange: -2,
+  ops: [Register('state')],
+  stackChange: 0,
 });
 
 OPCODE_METADATA(Op.PopulateLayout, {