Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling logging results in unbalanced operations #846

Closed
rwjblue opened this issue Sep 5, 2018 · 1 comment
Closed

Enabling logging results in unbalanced operations #846

rwjblue opened this issue Sep 5, 2018 · 1 comment
Labels
bug

Comments

@rwjblue
Copy link
Member

rwjblue commented Sep 5, 2018

At some point we have broken the ability to enable the internal debug logging (enabling it now seems to emit an error due to incorrect/unbalanced operations).

Does anyone have an idea of where to start digging into this?
@rwjblue rwjblue added the bug label Sep 5, 2018
@chiragpat
Copy link
Contributor

chiragpat commented Oct 1, 2018 •
edited

I was messing around with this, while I was working on #850. Seems like the InvokeComponentLayout used to change the stack by 2 but after this commit d4344e7#diff-7bb81772b9bff08cb2a8b4cb29f37dd5R567 it was simplified and now does not have the expected stack change.

chiragpat added a commit to chiragpat/glimmer-vm that referenced this issue Oct 1, 2018
@chiragpat
Fix debug issues reported in glimmerjs#846
73a3967
@chiragpat chiragpat mentioned this issue Oct 1, 2018
Merged
chadhietala added a commit that referenced this issue Oct 2, 2018
@chadhietala
Merge pull request #857 from chiragpat/debug_fix
7b41a7b 
Fix debug issues reported in #846
@dependabot-preview dependabot-preview bot mentioned this issue Oct 17, 2018
Merged
@dependabot-preview dependabot-preview bot mentioned this issue Nov 27, 2018
Closed
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
@dependabot-preview dependabot-preview bot mentioned this issue Jan 7, 2019
Closed
This was referenced Jan 28, 2019
Closed
Merged
@dependabot-preview dependabot-preview bot mentioned this issue Feb 11, 2019
Closed
This was referenced Mar 18, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rwjblue @chiragpat