-
Notifications
You must be signed in to change notification settings - Fork 190
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix nested calls to helpers in dynamic helpers
Currently, nested calls to helpers in dynamic helpers cause problems because the nested helper overwrites the register that we were using to pass along the helper definition. This is actually a worse way of doing something that the `Dup` opcode is designed to do anyways, so I updated to do that, following the same pattern in DynamicModifiers. Added tests for both dynamic helpers and modifiers with nested helpers.
- Loading branch information
Chris Garrett
committed
Apr 1, 2021
1 parent
1bc620b
commit b832ff2
Showing
4 changed files
with
90 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters