Simplifies JitRuntime, JitContext, Environment setup
#1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
approved these changes
Feb 13, 2020
pzuraq
force-pushed
the
cleanup/simplify-runtime-and-context
branch
3 times, most recently
from
29b7fe2
to
77dc99b
Compare
|
@pzuraq needs a rebase |
added 2 commits
February 16, 2020 13:31
Currently there are three JitRuntime creation methods: - `CustomJitRuntime` - `JitRuntime` - `JitRuntimeFromProgram` With the recent refactors to Ember and Glimmer.js, we can consolidate these to a single method. In addition, this PR updates that method to take the `JitContext()` output directly, rather than requiring users create a program themselves. As part of this work, I also simplified tests to use the actual `JitContext` method rather than making a custom one. Finally, this PR makes `updateOperations` optional on the environment delegate. This allows environments that do not want to update, such as streaming SSR, to opt out of updates altogether.
krisselden
force-pushed
the
cleanup/simplify-runtime-and-context
branch
from
77dc99b
to
d5dd04c
Compare
rwjblue
changed the title
JitRuntime, JitContext, Environment setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there are three JitRuntime creation methods:
CustomJitRuntimeJitRuntimeJitRuntimeFromProgramWith the recent refactors to Ember and Glimmer.js, we can consolidate
these to a single method. In addition, this PR updates that method to
take the
JitContext()output directly, rather than requiring userscreate a program themselves.
As part of this work, I also simplified tests to use the actual
JitContextmethod rather than making a custom one.Finally, this PR makes
updateOperationsoptional on the environmentdelegate. This allows environments that do not want to update, such as
streaming SSR, to opt out of updates altogether.