ESLint: Enable node/no-unpublished-import rule
#1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts everywhere ... since they will be compiled out of the build automatically
rwjblue
approved these changes
Feb 14, 2020
| @@ -16,6 +16,7 @@ module.exports = { | |||
| plugins: ['@typescript-eslint', 'prettier', 'qunit'], | |||
| settings: { | |||
| node: { | |||
| allowModules: ['@glimmer/debug', '@glimmer/local-debug-flags'], | |||
There was a problem hiding this comment.
FWIW, these are actual modules that can be resolved. Why do we have to explicitly whitelist them?
There was a problem hiding this comment.
Is it because those packages aren’t published (and therefore not listed in the respective package.json dependencies)?
There was a problem hiding this comment.
it's imported in a few lib folders, so it would have to be a non-dev dependency, but since it's a private package that won't work. best solution I could come up with was this one.
There was a problem hiding this comment.
Ya, makes sense. We avoided this with @glimmer/env by actually publishing...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://github.com/mysticatea/eslint-plugin-node/blob/master/docs/rules/no-unpublished-import.md