Fix TS performance regression in compiler types #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
approved these changes
Feb 17, 2020
krisselden
force-pushed
the
compiler-types
branch
from
685851d
to
59b1276
Compare
rwjblue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved compiler types and fixes performance issues with type checking opcode-compiler statements and expressions that get even worse if you upgrade past typescript 3.6.
The Compiler implementation is shared since it is the same and only varies by generics now (as I think was originally intended).
The mapping types are now derived from Statement and TupleExpression, so they are related and stay in sync.
Also, move const ATTR_BLOCK out of compiler since it wasn't used there nor seemed related since it is only used in the component helper and WrappedComponent. Moved to component helper which uses it and WrappedComponent uses it but already was dependent on the component helper.