Improve development build performance (remove the Error instances created for autotracking transactions)
#1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These errors are expensive to generate, and have become problematic for development mode in general. The plan is to remove them for now, and try to bring them back some time in the future in a opt-in way that is more conventional and comprehensive (e.g. show all possible consumption locations, not just the first one).
rwjblue
approved these changes
Mar 25, 2020
|
🎉 Porting some stuff to tracked has totally murdered my performance in tests, and I've verified that this is the cause. I have a test module that takes 110s to run, or 2s to run with the error construction removed. Any idea when this will be released? Trying to decide whether or not to hold up my porting to tracked until this is released so dev cycle, CI time, etc., doesn't skyrocket. |
rwjblue
changed the title
Error instances created for autotracking transactions)
|
@bendemboski - Started that process in emberjs/ember.js#18861. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These errors are expensive to generate, and have become problematic for
development mode in general. The plan is to remove them for now, and try
to bring them back some time in the future in a opt-in way that is more
conventional and comprehensive (e.g. show all possible consumption
locations, not just the first one).
Related: emberjs/ember.js#18834
Related: emberjs/ember.js#18798