Update comment for namespaced attribute detection. #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be worth to just dump phantom using xvfb to launch chrome? |
|
@chadhietala - Phantom 1.9 and 2.0 are Ember supported platforms so we still need to test against them. I do agree that we should test via chrome in Travis by default though (I am planning to do this in Ember too). |
|
ugh thanks @rwjblue. I think I was having flashbacks to dec 2014 doing this SVG stuff. |
mixonic
added a commit
that referenced
this pull request
Feb 7, 2016
Update comment for namespaced attribute detection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.