Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete BREAKING.md file #984

Merged
merged 1 commit into from
Feb 22, 2020
Merged

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Oct 29, 2019

It is unclear what this document is describing and what version it belongs to so we might as well delete it.

@rwjblue
Copy link
Member

rwjblue commented Oct 29, 2019

I think it was an attempt to explain the breaking changes (generally speaking) landed between 0.38 and 0.40(ish), but @wycats / @tomdale would have to confirm.

@Turbo87
Copy link
Member Author

Turbo87 commented Oct 29, 2019

then we should move it to the changelog IMHO

@rwjblue
Copy link
Member

rwjblue commented Feb 19, 2020

Has conflicts ATM, but happy to merge if you update @Turbo87 (sorry)

It is unclear what this document is describing and what version it belongs to so we might as well delete it...
@Turbo87
Copy link
Member Author

Turbo87 commented Feb 19, 2020

done :)

@rwjblue rwjblue merged commit 117743c into glimmerjs:master Feb 22, 2020
@Turbo87 Turbo87 deleted the breaking branch February 28, 2020 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants