Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow test runner to rerender between modules. #989

Merged
merged 1 commit into from
Nov 7, 2019

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Nov 7, 2019

Since all of our tests are synchronous, the QUnit UI never has a chance to rerender / update. This leads to a very long "white screen" when running the tests (on my local system, this is around 30s).

This adds a very small amount of async, just to allow the QUnit UI to rerender once per module completed.

Since all of our tests are synchronous, the QUnit UI never has a chance
to rerender / update. This leads to a very long "white screen" when
runnign the tests.

This adds a very small amount of async, just to allow the QUnit UI to
rerender once per module completed.
Copy link
Contributor

@chancancode chancancode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 💯

@rwjblue rwjblue merged commit c453240 into glimmerjs:master Nov 7, 2019
@rwjblue rwjblue deleted the breathing branch November 7, 2019 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants