Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support capitalized component names #22

Merged

Conversation

GavinJoyce
Copy link
Contributor

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rwjblue rwjblue requested a review from tomdale October 13, 2017 18:39
@rwjblue
Copy link
Member

rwjblue commented Oct 13, 2017

@tomdale - Mind reviewing this also?

@tomdale
Copy link
Contributor

tomdale commented Oct 17, 2017

@rwjblue @GavinJoyce LGTM2

@tomdale tomdale merged commit 23f886a into glimmerjs:master Oct 17, 2017
@GavinJoyce GavinJoyce deleted the gj/support-capitalized-components branch October 17, 2017 16:39
jmbejar added a commit to jmbejar/glimmer-blueprint that referenced this pull request Nov 2, 2017
… the component name

This follows the changes made in the glimmer-web-component package
(glimmerjs/glimmer-web-component#22)
Turbo87 pushed a commit to Turbo87/glimmer.js that referenced this pull request Nov 24, 2017
… the component name

This follows the changes made in the glimmer-web-component package
(glimmerjs/glimmer-web-component#22)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants