-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove @glimmer/web-component advice for async methods #62
Comments
FWIW, I tried both the @robbiepitts - were you able to successfully get babel-polyfill to work with Glimmer? babel-polyfill internally uses I'm new to ember-cli, so maybe I'm missing something? |
I got it to work by hacking in I would take this further, but it looks like people with more experience in this have noticed that the static approach in rollup-with-dependencies.ts is not correct/scalable: glimmerjs/glimmer-application-pipeline#19 removes it entirely. I assume the PR will also move configuration of babel more towards the |
Also of interest: glimmerjs/glimmer-application-pipeline#83 |
@chrishyle We need to do something about this part of the docs. We now have no good recommendation for getting async/await to work but we're talking about using it. |
Decided to learn some glimmer tonight, started watching the getting started video, ended up here... I agree with @robbiepitts. |
@robbiepitts @locks I walked through a temporary fix earlier with @rwjblue after running into this problem myself and finding 5+ unsolved issues about it. I can help with one of the following:
What do you think? |
Done! |
In
tracked-properties.md
:I think this is bad advice. This solves the problem by avoiding es5 compilation, which is a terribly broken thing that I think should go away (no prod builds; no minification). Also, installing a package that you don't need to alter the build pipeline in a mysterious way seems bobo to me.
I think what we should be doing is recommending they install babel-polyfill, which directly solves the problem of not having
regeneratorRuntime
.The text was updated successfully, but these errors were encountered: