Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates towards noImplicitAny #148

Merged
merged 2 commits into from Oct 5, 2018
Merged

updates towards noImplicitAny #148

merged 2 commits into from Oct 5, 2018

Conversation

givanse
Copy link
Contributor

@givanse givanse commented Sep 28, 2018

No description provided.

@givanse givanse mentioned this pull request Sep 28, 2018
Closed
rwjblue
rwjblue reviewed Sep 28, 2018
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looking good to me.

@chadhietala chadhietala merged commit 88da536 into glimmerjs:master Oct 5, 2018
@givanse givanse deleted the noImplicitAny branch October 5, 2018 01:22
@rwjblue rwjblue added the bug label Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue left review comments

@chadhietala chadhietala Awaiting requested review from chadhietala

@tomdale tomdale Awaiting requested review from tomdale

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@givanse @rwjblue @chadhietala