Remove need for @tracked on getters #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change aligns the Glimmer.js @Tracked implementation with Ember, where further improvements to the design have been made. In particular, values consumed through templates (as represented by References) now participate in the autotracking system. This removes the need for annotating getters with the @Tracked decorator. Instead, getters become "tracked" automatically as a by-product of accessing tracked properties during their execution. As of this change, applying @Tracked to a getter will produce an error message with instructions to remove the decorator.
tomdale
force-pushed
the
remove-tracked-computed
branch
from
cbca1c5
to
e7544e2
Compare
rwjblue
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change aligns the Glimmer.js
@trackedimplementation with Ember, where further improvements to the design have been made.In particular, values consumed through templates (as represented by References) now participate in the autotracking system. This removes the need for annotating getters with the
@trackeddecorator. Instead, getters become "tracked" automatically as a by-product of accessing tracked properties during their execution.As of this change, applying
@trackedto a getter will produce an error message with instructions to remove the decorator.