[FEAT] Upgrade the VM to v0.61.1 #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzuraq
force-pushed
the
upgrade-vm-0.61.0
branch
from
926c086
to
afd00b7
Compare
Upgrades the VM to the latest version
pzuraq
force-pushed
the
upgrade-vm-0.61.0
branch
from
afd00b7
to
220bed1
Compare
pzuraq
changed the title
rwjblue
reviewed
Sep 2, 2020
| @@ -281,7 +281,7 @@ module(`[@glimmer/core] non-interactive rendering tests`, () => { | |||
| } catch (err) { | |||
| assert.ok( | |||
| err.message.match( | |||
| "You tried to reference {{name}} from the template-only-component template, which doesn't have an associated component class. Template-only components can only access args passed to them. Did you mean {{@name}}?" | |||
| 'You attempted to access `this` on a template only component, template-only-component. Template only components do not have a `this` context, and can only access arguments' | |||
There was a problem hiding this comment.
Hmm, why do we loose the nicer error? If this is due to an upstream change, we should work to fix it...
There was a problem hiding this comment.
it is, and it's noted in the location of the error with a link to this issue: glimmerjs/glimmer-vm#1153
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades the VM to the latest version