Adds @cached decorator

[NullVoxPopuli]

This is the same implementation as ember and the polyfill

[snewcomer]

emberjs/rfcs#566

Beautiful!

[pzuraq]

I think this needs to be implemented in Ember as well, since Ember has its own implementation of @glimmer/tracking for the moment still

[NullVoxPopuli]

@pzuraq why is that? is it worth using this effort to make ember use this @glimmer/tracking?

[NullVoxPopuli]

ah looks like there is computed interop in there 🤔
alright, I'll do a separate PR to emberjs for @cached Though, I wonder if it can re-export this cached? 🤔

[tehhowch]

Would you mind adding tests for using the decorator with private getters? Or is caching a private getter expected to never be supported?

Ref: ember-polyfills/ember-cached-decorator-polyfill#93

[NullVoxPopuli]

Afaik, It's not possible with today's decorators because of how the transpiling happens.

But it should work with the new decorators proposal, afaik. @pzuraq would have details. ;)

[NullVoxPopuli]

looks like the errors here in CI are present on every other PR 🎉

[NullVoxPopuli]

Ember version: emberjs/ember.js#19772

[mydea]

Since this has landed in ember, would it be possible to merge this as well? As of now, e.g. when using Typescript it is a bit akward, since cached types do not exist in @glimmer/tracking but can actually be imported from that path 😅

[rwjblue]

Ya, we should definitely get this landed.

@NullVoxPopuli - Can you rebase to kick off a new set of tests?

[NullVoxPopuli]

it's already up to date / fully rebased

[NullVoxPopuli]

@rwjblue any way you/we/i can click the "re-run all jobs button"?

[rwjblue]

Hmm, no? There is no "re-run all" button on the checks tab.

[knownasilya]

🎉