Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit 'projectPath' for Broccoli Plugin #93

Merged
merged 2 commits into from Dec 19, 2017
Merged

Conversation

chadhietala
Copy link
Member

This makes the broccoli plugin actually usable within an ember-cli project. Prior to this commit we assuming passing an entire project root into the plugin however in practice just the src directory will be used. This moves to an implicit assumption that the inputPath is the root of the project. This means the tree that is passed to the plugin must contain the package.json.

@rwjblue
Copy link
Member

rwjblue commented Dec 2, 2017

Not sure how this wouldn’t cause recursive rebuilds on systems without watchman because the project tmp would be inside this root tree being passed in, and change events in ./tmp would trigger a rebuild.

What am I missing here?

@chadhietala
Copy link
Member Author

chadhietala commented Dec 2, 2017

You need to merge the package.json in. The MUDelegate requires a package.json.

@rwjblue
Copy link
Member

rwjblue commented Dec 2, 2017

So you are saying we would clone the package.json into an unwatched tree, funnel src (as a watched tree), then merge the two together? In other words, we would not be passing in the project root as the root tree, we would just be making it seem like that’s what we are doing?

@chadhietala
Copy link
Member Author

@rwjblue Correct. @tomdale Likely can talk more about why the package.json needs to be there at all.

@tomdale
Copy link
Contributor

tomdale commented Dec 5, 2017

The package.json is needed to infer the module prefix name.

@chadhietala chadhietala merged commit 5734e66 into master Dec 19, 2017
@chadhietala chadhietala deleted the broccoli-plugin branch December 19, 2017 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants