UI fix for drops outside of case logic #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the bug report, and the pull request! The commit seems to be empty though? |
|
Oops, sorry. The pertinent change is here: 9c8e7af |
|
Ah, great, thanks. Maybe merge the move == null check with the "if (startX == endX && startY == endY)" check just a little earlier? |
glinscott
added a commit
that referenced
this pull request
Dec 7, 2012
UI fix for drops outside of case logic
|
Thanks! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you drag a piece onto an illegal square or off the table, no other pieces can be moved unless the badly dropped piece is legally dropped.
This adds an extra fallback clause if no legal move conditions are met on drop with the same result as 'same square'.