forked from mastodon/mastodon
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge upstream changes #2246
Merged
ClearlyClaire
merged 101 commits into
glitch-soc:main
from
ClearlyClaire:glitch-soc/merge-upstream
Jun 11, 2023
Merged
Merge upstream changes #2246
ClearlyClaire
merged 101 commits into
glitch-soc:main
from
ClearlyClaire:glitch-soc/merge-upstream
Jun 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ht destructive implications (mastodon#23261)
…oc/merge-upstream
Port e9385e9 to glitch-soc Signed-off-by: Claire <claire.github-309c@sitedethib.com>
…oc/merge-upstream
Port b3f9a0d to glitch-soc Signed-off-by: Claire <claire.github-309c@sitedethib.com>
…oc/merge-upstream Conflicts: - `app/javascript/mastodon/load_locale.js`: The file moved to `app/javascript/mastodon/locales/load_locale.ts`. Ported the changes there and deleted `app/javascript/mastodon/load_locale.js`. - `app/javascript/mastodon/locales/index.js`: The file moved to `app/javascript/mastodon/locales/index.ts`. Did *not* port the changes as I want to try something a bit different.
Port b0780cf to glitch-soc Signed-off-by: Claire <claire.github-309c@sitedethib.com>
ClearlyClaire
force-pushed
the
glitch-soc/merge-upstream
branch
from
June 10, 2023 14:18
af97cc5
to
9e66c07
Compare
…oc/merge-upstream Conflicts: - `config/initializers/simple_form.rb`: Upstream added a new simple_form component, where we had an extra one. Kept both components.
Port acc419b to glitch-soc Signed-off-by: Claire <claire.github-309c@sitedethib.com>
…on sign-up Port SCSS from 0766c9a to glitch-soc Signed-off-by: Claire <claire.github-309c@sitedethib.com>
Port bacb674 to glitch-soc Co-authored-by: Liam Cooke <liam@liamcooke.com> Co-authored-by: John Holdun <john@johnholdun.com> Co-authored-by: Effy Elden <effy@effy.space> Co-authored-by: Lina Reyne <git@lina.pizza> Co-authored-by: Lina <20880695+necropolina@users.noreply.github.com> Co-authored-by: Claire <claire.github-309c@sitedethib.com> Signed-off-by: Claire <claire.github-309c@sitedethib.com>
Port c2c3961 to glitch-soc Signed-off-by: Claire <claire.github-309c@sitedethib.com>
Port a6c898f to glitch-soc Signed-off-by: Claire <claire.github-309c@sitedethib.com>
…nippets for / Port 1483a3d to glitch-soc Signed-off-by: Claire <claire.github-309c@sitedethib.com>
…oc/merge-upstream Conflicts: - `config/initializers/content_security_policy.rb`: Kept our version, it was not affected by upstream's bug.
Port fb5bf5c to glitch-soc Signed-off-by: Claire <claire.github-309c@sitedethib.com>
Port e4fd950 to glitch-soc Signed-off-by: Claire <claire.github-309c@sitedethib.com>
…oc/merge-upstream Conflicts: - `app/views/settings/preferences/appearance/show.html.haml`: Upstream fixed a translation bug in the theme selector that is absent from glitch-soc due to our different theming system. Discarded upstream changes. - `streaming/index.js`: Upstream changed the signature of a function to change its return type. This is not a real conflict, the conflict being caused by an extra argument in glitch-soc's code. Applied upstream's change while keeping our extra argument.
…oc/merge-upstream Conflicts: - `app/views/settings/preferences/appearance/show.html.haml`: Conflict because glitch-soc does not have a theme selector here.
The i18n failures is because the code now checks that there are no inconsistent definitions of source strings, and some have been redefined in changes that have not yet been ported (onboarding, DM, …) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-intl
, modernizing the code but at the cost of changing how locales are generated and loaded. Expect bugs.This also drops
statsd
support because the code used for it is unmaintained, inefficient, and would prevent moving to Rails 7.Merge upstream changes up to 44cd88a
This entirely rewrites how locales are generated and loaded. This is cleaner and simpler, but glitch-soc had some hacks to handle translations, so there may be some edge cases.
Some things are also known to be broken at this point because they were broken upstream, but this should be addressed later in this same PR.
Conflicts
.github/dependabot.yml
:Updated upstream, but we've deleted it.
Keep it deleted.
app/javascript/mastodon/locales/index.js
:Reworked upstream, but the code was mostly in
app/javascript/locales/index.js
in glitch-soc.Updated that file accordingly.
app/javascript/packs/public.jsx
:Not a real conflict, but different imports in glitch-soc and upstream.
app/views/layouts/application.html.haml
:Conflict due to locales loading and theme system discrepancies.
Updated in our own way.
app/views/layouts/embedded.html.haml
:Conflict due to locales loading and theme system discrepancies.
Updated in our own way.
config/webpack/generateLocalePacks.js
:Deleted upstream, as upstream now directly loads the JSON at runtime.
Deleted as well, will switch to runtime loading in an upcoming commit.
config/webpack/shared.js
:Not a real conflict, but different imports in glitch-soc and upstream.
config/webpack/translationRunner.js
:Mostly deleted upstream, to be replaced with
formatjs-formatter.js
instead.Moved the glitch-soc logic there and deleted the file.
Ported changes
Merge up to b922ad7
Conflicts
package.json
:Upstream changed various script definitions in lines surrounding the one for
i18n:extract
, which had glitch-soc-specific changes.Updated the scripts as upstream did, while keeping our changes to
i18n:extract
.Ported changes
Merge upstream changes up to e9385e9
Conflicts
None
Ported changes
Merge upstream changes up to 5fae2de
Conflicts
None
Ported changes
Postponed changes
Merge upstream changes up to b0780cf
This fixes some of the issues introduced in the first merge.
Conflicts
app/javascript/mastodon/load_locale.js
:The file moved to
app/javascript/mastodon/locales/load_locale.ts
.Ported the changes there and deleted
app/javascript/mastodon/load_locale.js
.app/javascript/mastodon/locales/index.js
:The file moved to
app/javascript/mastodon/locales/index.ts
.Did not port the changes as I want to try something a bit different.
Ported changes
Merge upstream changes up to d8b0a73
Conflicts
config/initializers/simple_form.rb
:Upstream added a new simple_form component, where we had an extra one.
Kept both components.
Ported changes
Postponed changes
Merge upstream changes up to b85c387
Conflicts
config/initializers/content_security_policy.rb
:Kept our version, it was not affected by upstream's bug.
Ported changes
Postponed changes
Skipped changes
Merge upstream changes up to 16dd3f0
Conflict changes
app/views/settings/preferences/appearance/show.html.haml
:Upstream fixed a translation bug in the theme selector that is absent from glitch-soc due to our different theming system.
Discarded upstream changes.
streaming/index.js
:Upstream changed the signature of a function to change its return type.
This is not a real conflict, the conflict being caused by an extra argument in glitch-soc's code.
Applied upstream's change while keeping our extra argument.
Ported changes
None
Merge up to 42a0898
No conflicts or nothing to port
Additional changes
locales
common chunk that used to contain, well, locales handling code, instead have webpack generate acommon
chunk like upstream