Fix crash when S3_ALIAS_HOST or S3_CLOUDFRONT_HOST have a path component #25018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClearlyClaire
force-pushed
the
fixes/path-in-s3-hostname
branch
from
fe66f82
to
88f2e05
Compare
|
cc @mjankowski |
Oops! Overlooked on previous changes. My bad. Your fix looks good -- maybe add some specs with a const value including a host/path to avoid regression? |
ClearlyClaire
force-pushed
the
fixes/path-in-s3-hostname
branch
from
88f2e05
to
505afc7
Compare
|
Good point, changed it accordingly. |
renchap
approved these changes
Jun 1, 2023
ClearlyClaire
added a commit
to ClearlyClaire/mastodon
that referenced
this pull request
Jun 5, 2023
See mastodon#24177 for people running into the issue, and mastodon#25018 for S3_ALIAS_HOST being allowed to have a path component.
supernovae
pushed a commit
to Universeodon-com/mastodon
that referenced
this pull request
Jun 7, 2023
skerit
pushed a commit
to 11ways/mastodon
that referenced
this pull request
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those variables are allowed to have a path component despite their name.