Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for pleroma rights API #823

Conversation

ClearlyClaire
Copy link

Adapted from https://git.pleroma.social/pleroma/mastofe/commit/0c3fff7a9c7ae210c43232145648d5e45238bdc8

I'm not too sure about adding something exclusive to pleroma, but that might make their job downstream easier.

Conflicts:
	app/controllers/api/v1/mutes_controller.rb
	config/locales/simple_form.pl.yml
@hannahwhy
Copy link
Member

I don't have a problem with this change if it doesn't cause errors (either user- or developer-console-visible) in Mastodon instances.

(MAX_TOOT_CHARS was a change from Pleroma too; this rights API change is a bit more involved, but I just wanted to add that glitch-soc has prior history with similar changes)

@lanodan
Copy link

lanodan commented Nov 22, 2018

Well I’m not against this at all but this quite raises a question for me, as I could have upstreamed this one or probably others too.

What should I/we upstream to glitch-soc, specially as for like more unstable/WIP modifications it might be better to be in pleroma’s repository so it’s more easily modifiable?

My current answer to this one is:

  • Does it contributes for the usage in upstream?
  • Will it help me for further rebasing/merging of upstream’s updates?

And this shouldn’t break anything for glitch-soc (in fact most modifications I made other than branding/configuration shouldn’t break stuff).

@ClearlyClaire
Copy link
Author

I only did that because you suggested merging it in the previous PR.
I'm not too sure what pleroma-specific things to merge in glitch-soc, but this one doesn't seem to be a hassle to maintain, and I guess I would merge it if that makes things easier on your side.
However, if you are planning to change this API, this would probably make more sense not to be merged. Your call!

@ClearlyClaire ClearlyClaire deleted the glitch-soc/features/pleroma-delete branch March 14, 2019 14:37
@ClearlyClaire ClearlyClaire restored the glitch-soc/features/pleroma-delete branch March 14, 2019 14:37
@ClearlyClaire ClearlyClaire reopened this Mar 14, 2019
Base automatically changed from master to main January 21, 2021 15:28
@github-actions
Copy link

github-actions bot commented Dec 9, 2022

This pull request has merge conflicts that must be resolved before it can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants