Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: glitch hides github login behind a login button that is now clicked first by puppeteer #11

Merged
merged 2 commits into from Sep 26, 2018

Conversation

zieka
Copy link
Contributor

@zieka zieka commented Sep 25, 2018

closes #9

@zieka
Copy link
Contributor Author

zieka commented Sep 25, 2018

@gr2m, when you get a chance, could you review

Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thank you! 💐

@gr2m gr2m merged commit 2b160d1 into glitch-tools:master Sep 26, 2018
@glitch-tools-bot
Copy link
Collaborator

🎉 This PR is included in version 1.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Evaluation failed: TypeError: Cannot read property 'click' of null
3 participants