Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always fill the File object with all available response data #76

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Always fill the File object with all available response data #76

merged 1 commit into from
Oct 10, 2022

Conversation

SteppingHat
Copy link
Contributor

@SteppingHat SteppingHat commented May 29, 2022

When calling upload() and listFiles(), the resulting File objects that are created doesn't include all of the available data sent back in the Backblaze response. This behaviour is inconsistent with other methods that create File objects from responses (i.e. copy(), getFile() and finishLargeFile()).

This change simply adds the data returned from the response into the already existing properties within the File class.

@SteppingHat
Copy link
Contributor Author

SteppingHat commented Jun 1, 2022

@mhetreramesh / @mlambley Any chance we can review this change?

@mlambley mlambley merged commit 3abcf1a into gliterd:master Oct 10, 2022
@mlambley
Copy link
Member

Thanks buddy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants