NativeStateDRM: fix running without current mode #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is no current mode set (likely if framebuffer emulation is disabled), we need to work out the connector->encoder->crtc chain on our own. Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
jessebarker
reviewed
Jun 28, 2017
| @@ -267,10 +267,16 @@ NativeStateDRM::init() | |||
|
|
|||
| // Find a suitable encoder | |||
| for (int e = 0; e < resources_->count_encoders; e++) { | |||
| int found = 0; | |||
There was a problem hiding this comment.
This should be a bool.
LeSpocky
pushed a commit
to LeSpocky/ptxdist
that referenced
this pull request
Jul 3, 2017
Also fix the DRM backend to be able to run without a currently set mode. Patch is on its way to upstream: glmark2/glmark2#34 Signed-off-by: Lucas Stach <l.stach@pengutronix.de> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
|
I have merged this patch at d3840c8, after applying the change Jesse suggested (int->bool). Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is no current mode set (likely if framebuffer emulation is
disabled), we need to work out the connector->encoder->crtc chain on
our own.
Signed-off-by: Lucas Stach l.stach@pengutronix.de