Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc fixes #27

Merged
merged 4 commits into from
May 10, 2024
Merged

misc fixes #27

merged 4 commits into from
May 10, 2024

Conversation

abhidg
Copy link
Contributor

@abhidg abhidg commented May 9, 2024

  • fix: raise Error, otherwise returns None
  • Add some type hints, fix typo
  • resources: use set.intersection and remove if statement

@abhidg abhidg requested a review from pipliggins May 9, 2024 11:50
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 88.46154% with 3 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@2d2c5ad). Click here to learn what that means.

Files Patch % Lines
fhirflat/resources/base.py 80.00% 1 Missing ⚠️
fhirflat/resources/location.py 50.00% 1 Missing ⚠️
fhirflat/resources/organization.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #27   +/-   ##
=======================================
  Coverage        ?   94.54%           
=======================================
  Files           ?       35           
  Lines           ?     1228           
  Branches        ?        0           
=======================================
  Hits            ?     1161           
  Misses          ?       67           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@pipliggins pipliggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@abhidg abhidg merged commit c6d2738 into main May 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants