Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fio2_percent and oxygen_flow_rate #188

Merged
merged 17 commits into from
Nov 14, 2023
Merged

Add fio2_percent and oxygen_flow_rate #188

merged 17 commits into from
Nov 14, 2023

Conversation

pipliggins
Copy link
Collaborator

No description provided.

This was linked to issues Sep 26, 2023
@globaldothealth globaldothealth deleted a comment from github-actions bot Sep 26, 2023
Copy link
Collaborator

@ekamau ekamau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @pipliggins - lots of work!
all look very good; and just a few minor changes to look at ..

isaric/parsers/ccp-guinea.toml Outdated Show resolved Hide resolved
isaric/parsers/sprintsari-australia.toml Outdated Show resolved Hide resolved
isaric/parsers/idor-brazil.toml Show resolved Hide resolved
isaric/parsers/isaric-ccpuk.toml Outdated Show resolved Hide resolved
@pipliggins
Copy link
Collaborator Author

@sadiekelly would you mind checking the guinea parser particularly? It seems like it was merged before your review changes were applied, so it's worth going back and double checking I caught everything.

isaric/parsers/ccp-cameroon.toml Outdated Show resolved Hide resolved
isaric/parsers/isaric-ecmo.toml Show resolved Hide resolved
@globaldothealth globaldothealth deleted a comment from github-actions bot Sep 27, 2023
@globaldothealth globaldothealth deleted a comment from github-actions bot Oct 2, 2023
@@ -298,6 +298,11 @@
description = "Health worker?"
ref = "Y/N/NK"

[subject.works_lab]
field = "microb"
description = "Employee of a microbiology laboratory"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pipliggins I think for creating the works_lab supertype we'd only map the Y responses if the question specifically asks about working in a microbiology lab, as someone could respond 'N' to not working in a microbiology lab but they are still a lab worker, what do you think?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sadiekelly so you mean if a question asks 'are you a microbiology worker?' we'd only map the yes responses to works_lab, but both Y and N for works_microbiology_lab? Yes, I think that makes sense. We might potentially need to consider this logic for other super types as well...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that's right, I think that's the best way. Which of the other super types are you thinking of?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't thought it through... but possibly for things like oxygen therapy - @abhidg remind me, if a 'false' response is given within combinedType = any, will that override a 'True' response from earlier?

If the question asks specifically about a microbiology lab
@pipliggins pipliggins mentioned this pull request Nov 1, 2023
@pipliggins pipliggins changed the title Add Works_lab and fio2_percent Add fio2_percent and oxygen_flow_rate Nov 1, 2023
@globaldothealth globaldothealth deleted a comment from github-actions bot Nov 2, 2023
@globaldothealth globaldothealth deleted a comment from github-actions bot Nov 8, 2023
@globaldothealth globaldothealth deleted a comment from github-actions bot Nov 8, 2023
@pipliggins
Copy link
Collaborator Author

@sadiekelly with the 2 new definitions here (oxygen_flow_rate and fio2) - do you think the presence of either/both should be used as an indicator of oxygen therapy in the visit table? Or just one?

Copy link

github-actions bot commented Nov 8, 2023

Summary of the missing optional fields for the ccp-cameroon parser:

table missing total_fields percentage_coverage
subject 17 56 69.642857%
visit 26 53 50.943396%
observation 29 70 58.571429%
SUBJECT                                         
dataset_id                                      False
sex_at_birth                                    False
ethnicity                                       False
works_microbiology_lab                          False
pregnancy_date_of_delivery                      False
pregnancy_post_partum                           False
preterm_infant                                  False
has_asplenia                                    False
has_chronic_respiratory_disease                 False
diabetes_type                                   False
has_apnoea                                      False
has_inflammatory_bowel_disease                  False
has_rare_disease_inborn_metabolism_error        False
has_solid_organ_transplant                      False
has_tuberculosis_past                           False
has_hiv_art                                     False
has_immunosuppression                           False
VISIT                                           
dataset_id                                      False
phase                                           False
treatment_corticosteroid_type                   False
treatment_corticosteroid_type_other             False
treatment_oxygen_mask_prongs                    False
treatment_antifungal_agent_type                 False
treatment_antibiotics_type                      False
treatment_anticoagulation                       False
treatment_ace_inhibitors                        False
treatment_arb                                   False
treatment_antimalarial_type                     False
treatment_high_flow_nasal_cannula               False
treatment_steroids                              False
treatment_immunosuppressant                     False
treatment_intravenous_fluids                    False
treatment_nsaid                                 False
treatment_neuromuscular_blocking_agents         False
treatment_cpr                                   False
treatment_offlabel                              False
treatment_respiratory_support                   False
treatment_colchicine                            False
treatment_immunoglobulins                       False
treatment_delirium                              False
treatment_delirium_type                         False
treatment_monoclonal_antibody                   False
treatment_pacing                                False
OBSERVATION                                     
avpu                                            False
acvpu                                           False
oxygen_flow_rate                                False
oxygen_flow_rate                                False
clinical_classification_critical_illness_scale  False
total_fluid_output_ml                           False
base_excess                                     False
clinical_frailty_score                          False
inability_to_walk_scale                         False
glasgow_coma_score                              False
blantyre_coma_score                             False
mid_upper_arm_circumference_cm                  False
fio2_percent                                    False
pao2_mmHg                                       False
pco2_mmHg                                       False
pH                                              False
richmond_agitation-sedation_scale               False
riker_sedation-agitation_scale                  False
other_symptom                                   False
mean_arterial_blood_pressure_mmHg               False
anorexia                                        False
bleeding                                        False
confusion                                       False
cyanosis                                        False
feeding_intolerance_pediatrics                  False
hepatomegaly                                    False
inability_to_walk                               False
irritability_pediatrics                         False
lung_sounds                                     False
heart_sounds                                    False

@globaldothealth globaldothealth deleted a comment from github-actions bot Nov 8, 2023
@pipliggins
Copy link
Collaborator Author

Hi @sadiekelly, would you mind doing a final check through this? I think I've done everything we've discussed, but a second pair of eyes before I merge would be great!

@sadiekelly
Copy link
Collaborator

Hi @sadiekelly, would you mind doing a final check through this? I think I've done everything we've discussed, but a second pair of eyes before I merge would be great!

hi @pipliggins! I've added a few comments on the updated files - let me know if something is not clear - thanks!

@globaldothealth globaldothealth deleted a comment from github-actions bot Nov 14, 2023
@pipliggins pipliggins merged commit ca0b877 into main Nov 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 'works_lab' add FiO2 to observations
4 participants