Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goias (Brazil) parser #1316

Merged
merged 5 commits into from Oct 30, 2020
Merged

Goias (Brazil) parser #1316

merged 5 commits into from Oct 30, 2020

Conversation

AnyaLindstromBattle
Copy link
Contributor

First look at Goias parser, feedback wellcome.

Comment on lines +18 to +34
_AGE = "faixa_etaria"
_GENDER = "sexo"
_MUNICIPALITY = "municipio"
_DATE_CONFIRMED = "data_notificacao"
_DATE_SYMPTOMS = "data_inicio_sintomas"
_RECOVERED = "recuperado"
_ETHNICITY = "raca_cor"
_DIABETES = "diabetes"
_LUNG = "doenca_respiratoria"
_IMMUNOSUPPRESSED = "imunossupressao"
_CARDIOVASCULAR = "doenca_cardiovascular"

_COMORBIDITIES_MAP = {
"doenca_respiratoria": "lung disease",
"doenca_cardiovascular": "cardiovascular system disease",
"diabetes": "diabetes mellitus"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a lot of these lookups, and the functions that use them, are the same in other Brazil parsers (and maybe Portugal if/when we have one). It'd be good to move them to a common file in ingestion/functions/parsing/common so that there's a single place to go to read and update them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean the comorbidities or the column headers? Or both?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything, really; there's a "words used in Portuguese health reports" library waiting to be extracted here :).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Shall we merge this parser and then I can go off and do that as it will involve me changing all the other parsers anyway? If you're happy with the rest of it that is.

@iamleeg iamleeg merged commit 9bbda89 into main Oct 30, 2020
@iamleeg iamleeg deleted the goias branch October 30, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants