New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Goias (Brazil) parser #1316
Goias (Brazil) parser #1316
Conversation
_AGE = "faixa_etaria" | ||
_GENDER = "sexo" | ||
_MUNICIPALITY = "municipio" | ||
_DATE_CONFIRMED = "data_notificacao" | ||
_DATE_SYMPTOMS = "data_inicio_sintomas" | ||
_RECOVERED = "recuperado" | ||
_ETHNICITY = "raca_cor" | ||
_DIABETES = "diabetes" | ||
_LUNG = "doenca_respiratoria" | ||
_IMMUNOSUPPRESSED = "imunossupressao" | ||
_CARDIOVASCULAR = "doenca_cardiovascular" | ||
|
||
_COMORBIDITIES_MAP = { | ||
"doenca_respiratoria": "lung disease", | ||
"doenca_cardiovascular": "cardiovascular system disease", | ||
"diabetes": "diabetes mellitus" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a lot of these lookups, and the functions that use them, are the same in other Brazil parsers (and maybe Portugal if/when we have one). It'd be good to move them to a common file in ingestion/functions/parsing/common
so that there's a single place to go to read and update them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean the comorbidities or the column headers? Or both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything, really; there's a "words used in Portuguese health reports" library waiting to be extracted here :).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Shall we merge this parser and then I can go off and do that as it will involve me changing all the other parsers anyway? If you're happy with the rest of it that is.
First look at Goias parser, feedback wellcome.