Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/reminder local #3320

Closed
wants to merge 9 commits into from
Closed

Feature/reminder local #3320

wants to merge 9 commits into from

Conversation

msmannan02
Copy link
Contributor

This feature is discussed in detail regarding problem, reason and most feasible solution in the thread attached below

#2866

@evilaliv3
Copy link
Member

Thank you @msmannan02

I'm starting the review hoping to merge this in the next days.

\cc @elbill

@evilaliv3
Copy link
Member

Hello @msmannan02

I'm sorry for the delay.

I just managed to complete the review that you could find here: ebe20a7

I've already manually integrated your code in the branch feature branch.

I acknowledge the following changes:

  • we have applied a simplification to the code involving only one deadline. I will clarify about this on the related ticket.
  • we have fixed few bugs in the code due to use of wrong variables and wrong permissions.
  • we overall optimized the code using less variables. This would improve performances and as well simplify the code; we invite you to check these set of changes.

Thank you so much for your amazing contribution! :)

@evilaliv3
Copy link
Member

I will close this pull request as manually handled.

@evilaliv3 evilaliv3 closed this Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants