transforms: support babel6 #12
Conversation
A change in the output from Babel 6 emits default transforms as `module.default` rather than `module["default"]`. This changes the shape of the node that globalize-compiler examines.
|
I have a similar change for react-globalize-compiler in the works. edit: up now rxaviers/react-globalize-compiler#8 |
| }, | ||
| "devDependencies": { | ||
| "babel": "^5.6.14", | ||
| "babel": "^6.3.26", |
There was a problem hiding this comment.
Actually, we support babel ^5.6 or 6.x, right? If so, we don't need to restrict it to 6.x only.
There was a problem hiding this comment.
Nevermind, this is devDependencies...
There was a problem hiding this comment.
It would be great if we could have both vendored in for testing, but npm doesn't make that very easy.
There was a problem hiding this comment.
Yeap, it would.
@scottgonzalez, @jzaefferer, do you have any suggestions for that please? jQuery UI uses bower. Any projects doing this with npm that I could use as baseline?
There was a problem hiding this comment.
@ashleygwilliams Any suggestions? I feel like you recently had a tweet about something like this with Travis builds.
There was a problem hiding this comment.
You can have a subdirectory with its own package.json file, that would let you install different versions of Babel in different subdirectories. the TodoMVC repo does that, there's a main package.json for the repo and then others for each example.
There was a problem hiding this comment.
Thank you all for your comments. Since this isn't a blocker for this PR, I've moved this into #13
|
Excellent, thanks for the PR. |
|
I took the liberty to leave aside the changes to the package.json. |
A change in the output from Babel 6 emits default transforms as
module.defaultrather thanmodule["default"]. This changes the shapeof the node that globalize-compiler examines.
See also rxaviers/react-globalize-compiler#8