Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make basic globalize-compiler example more generic #637

Closed
rxaviers opened this issue Oct 6, 2016 · 0 comments
Closed

Make basic globalize-compiler example more generic #637

rxaviers opened this issue Oct 6, 2016 · 0 comments
Labels
quick change

Comments

@rxaviers
Copy link
Member

rxaviers commented Oct 6, 2016 •
edited
Loading

In app.js, the default locale is set with Globalize.locale('en'). That should happen on development only, therefore we could move that statement into development.html.

The default locale in production should be set by the compiler so it can generate production bundles for various locales.
@rxaviers rxaviers mentioned this issue Oct 6, 2016
Open
jacalata added a commit to jacalata/globalize that referenced this issue Aug 17, 2017
@jacalata
globalizejs#637-Make basic globalize-compiler example more generic
ff64909
@jacalata jacalata mentioned this issue Aug 17, 2017
Merged
jacalata added a commit to jacalata/globalize that referenced this issue Aug 17, 2017
@jacalata
Revert "globalizejs#637-Make basic globalize-compiler example more ge…
8f8a1d2 
…neric"

This reverts commit ff64909.
jacalata added a commit to jacalata/globalize that referenced this issue Aug 17, 2017
@jacalata
Examples: Make basic globalize-compiler example more generic
5e03bee 
Examples

Move Globalize.locale('en') to development.html

Fixes globalizejs#637
rxaviers pushed a commit that referenced this issue Apr 25, 2018
@jacalata @rxaviers
Examples: Make basic globalize-compiler example more generic
07671b5 
Move Globalize.locale('en') to development.html

Fixes #637
@snyk-bot snyk-bot mentioned this issue Nov 14, 2019
Open
@X-oss-byte X-oss-byte mentioned this issue Sep 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
quick change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rxaviers