Dynamically augment availableFormats #462

vectart · 2015-07-15T18:42:53Z

fixes #271

Dynamically augment availableFormats Fixes globalizejs#271

rxaviers · 2015-07-15T18:59:52Z

Awesome! All I see for now are some style issues, which I'm going to comment inline.

rxaviers · 2015-07-15T19:00:57Z

.travis.yml

@@ -7,3 +7,4 @@ before_install:
 install:
 - npm install
 - bower install
+sudo: false


cc @jzaefferer @scottgonzalez to comment on that

As long as its in a separate commit. Should also enable caching, see, for example, qunitjs/qunit#835

@vectart please could you include this? ☝️

Migrate to container-based infrastructure http://docs.travis-ci.com/user/migrating-from-legacy/

rxaviers · 2015-07-15T19:08:01Z

src/date/expand-pattern.js

@@ -38,6 +39,89 @@ return function( options, cldr ) {
 		);
 	}

+	function getBestMatchPattern( path, skeleton ) {
+		var availableFormats, ratedFormats, format;


I assume you want to define pattern as a variable local to this function, so it's not mixed up with pattern defined by the parent function.

rxaviers · 2015-07-15T19:28:33Z

@vectart I left a couple of comments, please just let me know on any questions and thanks so far.

vectart · 2015-07-15T19:56:13Z

@rxaviers Thanks for the useful comments, I've updated PR according to them

rxaviers · 2015-07-16T03:21:19Z

Please, could you rebase on master (git rebase master)? I've updated jscs and it will help us to find the coding style issues.

rxaviers · 2015-07-16T03:22:41Z

src/date/expand-pattern.js

+		maxLength = Math.max( formatA.length, formatB.length );
+		minLength = Math.min( formatA.length, formatB.length );
+
+		for ( index = 0; index < minLength; index++ ) {


It's ok using i instead of index here. :)

rxaviers · 2015-07-16T03:35:48Z

Interestingly, the augmentation for Globalize("en").formatDate(new Date(), {skeleton: "hhmm"}) worked just fine: '12:34 AM'. Although, it didn't work for Globalize("en").formatDate(new Date(), {skeleton: "HHmm"}): '0033' ('00:33'' expected). Please, could you check and also add this as a new test case?

rxaviers · 2015-07-16T03:41:36Z

Another worth doing test is checking against ICU... One difference I found is: EHmss gives 'Wed, 20:38:05' opposed to Wed 20:38:05 on ICU (http://demo.icu-project.org/icu4jweb/flexTest.jsp?pat=EHmss&_=en_US). The first one seems to have chosen by E alone and ms alone, then augmented ms into mss, then glued them. The second one seems to have chosen EHms, then augmented it into EHmss.

rxaviers · 2015-07-16T03:57:47Z

src/date/expand-pattern.js

+				timeSkeleton = getBestMatchPattern(
+					"dates/calendars/gregorian/dateTimeFormats/availableFormats",
+					timeSkeleton
+				);


You might need use getBestMatchPattern() for each date and time before the type assignment above. For example, MMMMh should give July, 8 PM (type medium) instead of July at 8 PM (type long). Because, "MMMM" will be converted into "LLLL".

rxaviers · 2015-07-22T11:43:55Z

@vectart just let me know when you have progress, so we can land this fix. Thanks for your great work so far.

reimplements globalizejs#462

Strate · 2016-04-01T19:36:14Z

How about to use builtin new Intl.DateTimeFormatter().resolved.pattern to get best-fit pattern?

Ref globalizejs#271 Closes globalizejs#604 Closes globalizejs#462

jquerybot added the CLA: Error label Jul 15, 2015

vectart force-pushed the master branch from ecf2647 to 049db10 Compare July 15, 2015 18:45

jquerybot added CLA: Valid and removed CLA: Error labels Jul 15, 2015

Component: Date formatter

c2ae893

Dynamically augment availableFormats Fixes globalizejs#271

vectart force-pushed the master branch from 049db10 to c2ae893 Compare July 15, 2015 18:48

rxaviers reviewed Jul 15, 2015
View reviewed changes

Component: Travis CI

aebb53f

Migrate to container-based infrastructure http://docs.travis-ci.com/user/migrating-from-legacy/

vectart force-pushed the master branch from 7ac6547 to 6312ba4 Compare July 15, 2015 19:06

rxaviers reviewed Jul 15, 2015
View reviewed changes

Date formatter: code style fix

aa6898d

vectart force-pushed the master branch from 6312ba4 to aa6898d Compare July 15, 2015 19:53

rxaviers reviewed Jul 16, 2015
View reviewed changes

rxaviers mentioned this pull request Aug 4, 2015

Date (skeletons): dynamically augment availableFormats #271

Closed

rxaviers mentioned this pull request Sep 10, 2015

E_UNSUPPORTED with date skeleton: 'yMMMM' #478

Closed

rxaviers added Current Sprint new feature labels Oct 10, 2015

Strate added a commit to megaplan/globalize that referenced this pull request Mar 22, 2016

fixes globalizejs#271,

e107ff6

reimplements globalizejs#462

Strate added a commit to megaplan/globalize that referenced this pull request Mar 22, 2016

fixes globalizejs#271, reimplements globalizejs#462

2307537

Strate mentioned this pull request Apr 3, 2016

DateTimeFormatter: Dynamically augment skeleton #604

Closed

JSFOwner removed the CLA: Valid label Nov 2, 2016

rxaviers removed the Current Sprint label Nov 18, 2016

rxaviers mentioned this pull request Mar 13, 2017

Date: Dynamically augment skeleton #703

Merged

rxaviers added a commit to rxaviers/globalize that referenced this pull request Mar 14, 2017

Date: Dynamically augment skeleton (3/3)

030691a

Ref globalizejs#271 Closes globalizejs#604 Closes globalizejs#462

rxaviers added a commit to rxaviers/globalize that referenced this pull request Mar 14, 2017

Date: Dynamically augment skeleton (3/3)

b378bd3

Ref globalizejs#271 Closes globalizejs#604 Closes globalizejs#462

rxaviers added a commit to rxaviers/globalize that referenced this pull request Mar 14, 2017

Date: Dynamically augment skeleton (3/3)

e2a424e

Ref globalizejs#271 Closes globalizejs#604 Closes globalizejs#462

rxaviers added a commit to rxaviers/globalize that referenced this pull request Mar 17, 2017

Date: Dynamically augment skeleton (3/3)

687207b

Ref globalizejs#271 Closes globalizejs#604 Closes globalizejs#462

rxaviers closed this in #703 Mar 17, 2017

rxaviers added this to the 1.3.0 milestone Mar 17, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dynamically augment availableFormats #462

Dynamically augment availableFormats #462

vectart commented Jul 15, 2015

rxaviers commented Jul 15, 2015

rxaviers Jul 15, 2015

jzaefferer Jul 15, 2015

rxaviers Jul 16, 2015

rxaviers Jul 15, 2015

rxaviers commented Jul 15, 2015

vectart commented Jul 15, 2015

rxaviers commented Jul 16, 2015

rxaviers Jul 16, 2015

rxaviers commented Jul 16, 2015

rxaviers commented Jul 16, 2015

rxaviers Jul 16, 2015

rxaviers commented Jul 22, 2015

Strate commented Apr 1, 2016

Dynamically augment availableFormats #462

Dynamically augment availableFormats #462

Conversation

vectart commented Jul 15, 2015

rxaviers commented Jul 15, 2015

rxaviers Jul 15, 2015

Choose a reason for hiding this comment

jzaefferer Jul 15, 2015

Choose a reason for hiding this comment

rxaviers Jul 16, 2015

Choose a reason for hiding this comment

rxaviers Jul 15, 2015

Choose a reason for hiding this comment

rxaviers commented Jul 15, 2015

vectart commented Jul 15, 2015

rxaviers commented Jul 16, 2015

rxaviers Jul 16, 2015

Choose a reason for hiding this comment

rxaviers commented Jul 16, 2015

rxaviers commented Jul 16, 2015

rxaviers Jul 16, 2015

Choose a reason for hiding this comment

rxaviers commented Jul 22, 2015

Strate commented Apr 1, 2016