Add "use strict" declarations to runtime files #676
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Runtime script files are now decorated with "use strict"; statements to keep them in compliance with standard stylecop and eslint style checks. Globalize code is already strict mode compliant. This change will not affect browser compatability since older browsers will simply ignore the statement. Currently only modifying the built "runtime" files.
|
About half the time the indentation is inconsistent with the following line of code. Otherwise this looks fine to me. |
|
Merged. Thank you @zbirkenbuel and @jzaefferer for reviewing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runtime script files are now decorated with
"use strict";statements to keep them in compliance with standard stylecop and eslint style checks. Globalize code is already strict mode compliant. This change will not affect browser compatibility since older browsers will simply ignore the statement. Currently only modifying the built "runtime" files.strict mode statements are contained within the module loader and factory function scopes so that they do not interfere with other files loaded in a browser.