New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "use strict" declarations to runtime files #676

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@zbirkenbuel
Contributor

zbirkenbuel commented Jan 18, 2017

Runtime script files are now decorated with "use strict"; statements to keep them in compliance with standard stylecop and eslint style checks. Globalize code is already strict mode compliant. This change will not affect browser compatibility since older browsers will simply ignore the statement. Currently only modifying the built "runtime" files.

strict mode statements are contained within the module loader and factory function scopes so that they do not interfere with other files loaded in a browser.

@jsf-clabot

This comment has been minimized.

Show comment
Hide comment
@jsf-clabot

jsf-clabot Jan 18, 2017

CLA assistant check
All committers have signed the CLA.

jsf-clabot commented Jan 18, 2017

CLA assistant check
All committers have signed the CLA.

Zack Birkenbuel
Build: Updated build templates to enable strict mode for runtime files
Runtime script files are now decorated with "use strict"; statements
to keep them in compliance with standard stylecop and eslint style checks.
Globalize code is already strict mode compliant.  This change will not
affect browser compatability since older browsers will simply ignore the
statement.  Currently only modifying the built "runtime" files.
@jzaefferer

This comment has been minimized.

Show comment
Hide comment
@jzaefferer

jzaefferer Mar 12, 2017

Contributor

About half the time the indentation is inconsistent with the following line of code. Otherwise this looks fine to me.

Contributor

jzaefferer commented Mar 12, 2017

About half the time the indentation is inconsistent with the following line of code. Otherwise this looks fine to me.

@rxaviers rxaviers added this to the 1.3.0 milestone Mar 17, 2017

@rxaviers rxaviers closed this in c2b26fa Apr 12, 2017

rxaviers added a commit that referenced this pull request Apr 12, 2017

@rxaviers

This comment has been minimized.

Show comment
Hide comment
@rxaviers

rxaviers Apr 12, 2017

Member

Merged. Thank you @zbirkenbuel and @jzaefferer for reviewing it.

Member

rxaviers commented Apr 12, 2017

Merged. Thank you @zbirkenbuel and @jzaefferer for reviewing it.

@zbirkenbuel zbirkenbuel deleted the HBOCodeLabs:strict branch Apr 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment