Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number: Fix parser to handle empty string #691

Merged
merged 2 commits into from
Feb 23, 2017

Conversation

rxaviers
Copy link
Member

Fixes #682
Ref #292
Ref #353

@jzaefferer
Copy link
Contributor

That's a lot of regular expressions that are pretty hard to read. I can't tell where in the tokenizer update you're now handling the empty string. But it seems to be working, so, up to you to add more comments or not.

@jzaefferer
Copy link
Contributor

I've looked at those, but barely understand anything. I think I'd have to spend a few hours to understand the context, probably not quite worth it as this point.

So, good to go :-)

@rxaviers
Copy link
Member Author

Sure thanks for the review

@rxaviers rxaviers merged commit fd84850 into globalizejs:master Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants