Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New v1.2.* returns 0 when number-parsing empty strings #682

Closed
samcic opened this issue Jan 28, 2017 · 1 comment
Closed

New v1.2.* returns 0 when number-parsing empty strings #682

samcic opened this issue Jan 28, 2017 · 1 comment
Labels
bug number module

Comments

@samcic
Copy link

samcic commented Jan 28, 2017

See

http://stackoverflow.com/questions/41748476/globalize-bug-in-new-v1-2-parsing-empty-string-returns-0

In short, there seems to be a regression in v1.2.* in that empty strings are now number parsed to 0 instead of NaN This seems rather non-intuitive, and I can't imagine it's intentional.
@rxaviers
Copy link
Member

This is indeed a bug and a regression that needs to be fixed. Thanks for reporting it.

rxaviers added a commit to rxaviers/globalize that referenced this issue Feb 20, 2017
@rxaviers
Number: Fix parser to handle empty string
b1745f1 
Fixes globalizejs#682
Ref globalizejs#292
Ref globalizejs#353
@rxaviers rxaviers mentioned this issue Feb 20, 2017
Merged
rxaviers added a commit to rxaviers/globalize that referenced this issue Feb 23, 2017
@rxaviers
Number: Fix parser to handle empty string
fd84850 
Fixes globalizejs#682
Ref globalizejs#292
Ref globalizejs#353
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug number module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rxaviers @samcic