Cache TXN ID #9
Closed
Cache TXN ID #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When walking graphs (hasPreReq), we can actually spend a lot of time doing the conversion from a 'hex+nonce' token string back to a binary ObjectId. Cache them in the flusher.
Merged
|
Closing as this has merge conflicts - resolved in #10. |
|
no problem. If you're interested in this one, you're probably also interested in the followups available from: I was waiting to propose them for when the first patch got approved, so as to not try to discuss too much at once. Those are they 'yellow' and 'green' lines in the original spreadsheet submission. Which does have a large effect on AssertionGrowth tests. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See go-mgo#454.
@jameinel this looks really useful, I hope you don't mind us pulling it to our fork. If you'd rather we didn't pull this, please let me know and we'll sort something out.
Thanks!