Use os.makedirs with exist_ok=True #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbayles
commented
Aug 10, 2022
| if basename: | ||
| os.makedirs(basename) | ||
| except OSError as error: | ||
| if error.errno != errno.EEXIST: |
There was a problem hiding this comment.
This block in the CPython source explains why this check isn't enough:
Cannot rely on checking for EEXIST, since the operating system could give priority to other errors like EACCES or EROFS
In #291, EACCES is the error code rather than EEXIST.
| finally: | ||
| assert raised | ||
|
|
||
| def test_dump_should_raise_if_create_sub_directories_fails(tmpdir): |
mauricioabreu
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #291
This PR updates
M3U8.dumpsuch that it usesexist_ok=Truewhen creating directories withos.makedirs.The intended behavior now obtains: