Skip and quota #393
Skip and quota #393
Conversation
| @@ -134,6 +134,8 @@ def __init__( | |||
| preserve_timestamp=False, | |||
| encrypt_data=False, | |||
| deadline=None, | |||
| skip_source_errors=False, | |||
| fail_on_quota_errors=False, | |||
There was a problem hiding this comment.
Let's add these to the list of params above, so that we get doc for these parameters. I think it's okay to just link to T-API docs which explain what they do, if that's convenient. (But obviously that may have to wait for said doc to be finished.)
There was a problem hiding this comment.
Ah missed those, added!
| "TransferClient.endpoint_manager_task_" | ||
| "skipped_errors({}, ...)".format(task_id) | ||
| ) | ||
| ) |
There was a problem hiding this comment.
This doesn't really matter, but may I suggest
self.logger.info(
"TransferClient."
"endpoint_manager_task_skipped_errors({}, ...)".format(task_id)
)as an alternative? The long-line rule may demand that we break things up, but I think the above is more readable because it avoids breaking a "long word".
There was a problem hiding this comment.
Agreed - I think this might have been auto-formatted since I tend to err in the direction of too long a line ^^"
globus_sdk/transfer/client.py
Outdated
| transfer, only files that were actually transferred, and does not include | ||
| any directories. | ||
| transfer or skipped due to skip_source_errors, only files that were | ||
| actually transferred, and does not include any directories. |
There was a problem hiding this comment.
This sentence is now very long; I think we should break it up.
I suggest:
Only files that were actually transferred are included.
This does not include files that were checked but skipped as part of a sync
transfer, files which were skipped due toskip_source_errors, or
directory names.
But if you have an alternate phrasing you prefer, go for it.
There was a problem hiding this comment.
Thank you! I slightly adjusted the phrasing to put directories first since that seems the most common case.
|
I made a very minor fix to |
Adds named arguments for skip_source_errors and fail_on_quota_errors to TransferData and methods for the new GET /task/<task_id>/skipped_errors and GET /endpoint_manager/task/<task_id>/skipped_errors to the TransferClient