Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination back to FlowsClient.list_flows #621

Merged
merged 3 commits into from
Oct 13, 2022

Conversation

sirosen
Copy link
Member

@sirosen sirosen commented Oct 12, 2022

The bulk of this change is a response data generator which produces test data. Although it would be nice to put this set of responses into the _testing data, it's not 100% clear where it should go. For now, this changeset punts on that question and puts the test data into the test module.

Now that Flows is supporting marker, the most barebones application of the pagination decorator for marker pagination is sufficient.

The bulk of this change is a response data generator which produces
test data. Although it would be nice to put this set of responses into
the `_testing` data, it's not 100% clear *where* it should go. For
now, this changeset punts on that question and puts the test data into
the test module.

Now that Flows is supporting `marker`, the most barebones application
of the pagination decorator for marker pagination is sufficient.
@sirosen
Copy link
Member Author

sirosen commented Oct 12, 2022

There were a few changes here after the first push because I made some mistakes in terms of support for older python versions.

`pyupgrade` will automatically "upgrade" this codepath to the py3.7+
variant once we drop support for py3.6
@sirosen sirosen merged commit 1b30434 into globus:main Oct 13, 2022
@sirosen sirosen deleted the paginated-flows-list branch October 13, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants