Add pagination back to FlowsClient.list_flows #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirosen
force-pushed
the
paginated-flows-list
branch
from
789501f
to
35141d7
Compare
The bulk of this change is a response data generator which produces test data. Although it would be nice to put this set of responses into the `_testing` data, it's not 100% clear *where* it should go. For now, this changeset punts on that question and puts the test data into the test module. Now that Flows is supporting `marker`, the most barebones application of the pagination decorator for marker pagination is sufficient.
sirosen
force-pushed
the
paginated-flows-list
branch
from
35141d7
to
fcc0e9e
Compare
|
There were a few changes here after the first push because I made some mistakes in terms of support for older python versions. |
kurtmckee
reviewed
Oct 12, 2022
`pyupgrade` will automatically "upgrade" this codepath to the py3.7+ variant once we drop support for py3.6
kurtmckee
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bulk of this change is a response data generator which produces test data. Although it would be nice to put this set of responses into the
_testingdata, it's not 100% clear where it should go. For now, this changeset punts on that question and puts the test data into the test module.Now that Flows is supporting
marker, the most barebones application of the pagination decorator for marker pagination is sufficient.