add session_required_policy to AuthorizationParamaterInfo #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaschaer
requested review from
ada-globus,
derek-globus,
kurtmckee and
sirosen
as code owners
kurtmckee
previously approved these changes
Dec 5, 2022
aaschaer
force-pushed
the
aaron/auth_policies
branch
2 times, most recently
from
9dbe4cf
to
b6e8809
Compare
kurtmckee
approved these changes
Dec 5, 2022
aaschaer
force-pushed
the
aaron/auth_policies
branch
from
1a4bee2
to
d5b9c16
Compare
kurtmckee
approved these changes
Dec 5, 2022
sirosen
approved these changes
Dec 7, 2022
There was a problem hiding this comment.
Yep, I'm good with this being our approach here.
If we find that some authorization_parameters fields are used exclusively in many (or all?) cases, we may want to pull that up into a (duplicate) ErrorInfo object, like err.info.session_required_policies. I'll need to learn more about the design here to be able to comment on what makes sense.
For now, this exposes the data which we know about, so I'm happy with it. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.