Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

βœ¨πŸš‡ Add official python 3.11 support #1161

Merged
merged 4 commits into from
May 21, 2023

Conversation

s-weigand
Copy link
Member

@s-weigand s-weigand commented Nov 5, 2022

Since python 3.11 came out some time ago we should also see we can already support it (mostly dependency issue).

Change summary

  • βœ¨πŸš‡ Added python 3.11 CI tests

Checklist

  • βœ”οΈ Passing the tests (mandatory for all PR's)
  • 🚧 Added changes to changelog (mandatory for all PR's)
  • πŸ§ͺ Adds new tests for the feature (mandatory for ✨ feature and 🩹 bug fix PR's)

@s-weigand s-weigand requested a review from a team as a code owner November 5, 2022 00:12
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2022

Binder πŸ‘ˆ Launch a binder notebook on branch s-weigand/pyglotaran/add-py311-support

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2022

Benchmark is done. Checkout the benchmark result page.
Benchmark differences below 5% might be due to CI noise.

Benchmark diff v0.7.0 vs. main

Parametrized benchmark signatures:

BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)

All benchmarks:

       before           after         ratio
     [9adf4a49]       [7e0285a7]
     <v0.7.0>                   
           failed           failed      n/a  BenchmarkOptimize.time_optimize(False, False, False)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(False, False, True)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(False, True, False)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(False, True, True)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(True, False, False)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(True, False, True)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(True, True, False)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(True, True, True)
             218M             219M     1.00  IntegrationTwoDatasets.peakmem_optimize
       1.01Β±0.02s         972Β±40ms     0.96  IntegrationTwoDatasets.time_optimize

Benchmark diff main vs. PR

Parametrized benchmark signatures:

BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)

All benchmarks:

       before           after         ratio
     [7e0285a7]       [e4f50434]
           failed           failed      n/a  BenchmarkOptimize.time_optimize(False, False, False)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(False, False, True)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(False, True, False)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(False, True, True)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(True, False, False)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(True, False, True)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(True, True, False)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(True, True, True)
             219M             217M     0.99  IntegrationTwoDatasets.peakmem_optimize
         972Β±40ms         972Β±40ms     1.00  IntegrationTwoDatasets.time_optimize

@s-weigand
Copy link
Member Author

Ok looks like numba does not support py311 officially yet

@sonarcloud
Copy link

sonarcloud bot commented Nov 21, 2022

Kudos, SonarCloud Quality Gate passed!Β  Β  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

jsnel
jsnel previously approved these changes Apr 28, 2023
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7e0285a) 88.3% compared to head (e4f5043) 88.3%.

Additional details and impacted files
@@          Coverage Diff           @@
##            main   #1161    +/-   ##
======================================
  Coverage   88.3%   88.3%            
======================================
  Files        107     107            
  Lines       5122    5122            
  Branches     847     960   +113     
======================================
  Hits        4525    4525            
  Misses       479     479            
  Partials     118     118            

β˜” View full report in Codecov by Sentry.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

jsnel
jsnel previously approved these changes May 20, 2023
@s-weigand
Copy link
Member Author

In #1276 it was tested that we get the same results with python 3.11 and numba 0.57.0

@sonarcloud
Copy link

sonarcloud bot commented May 21, 2023

Kudos, SonarCloud Quality Gate passed!Β  Β  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@jsnel jsnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally! πŸ˜„

@s-weigand s-weigand merged commit 6ebe06d into glotaran:main May 21, 2023
39 checks passed
@s-weigand s-weigand deleted the add-py311-support branch May 21, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants