Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧪 Test numba 0.57.0 result comparison #1276

Closed
wants to merge 4 commits into from

Conversation

s-weigand
Copy link
Member

@s-weigand s-weigand commented Apr 10, 2023

Since numba is one of our core dependencies and currently the blocker to support python 3.11, we should help them test their release candidate.

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)

@github-actions
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran/test-numba-0.57.0rc1

@github-actions
Copy link
Contributor

github-actions bot commented Apr 10, 2023

Benchmark is done. Checkout the benchmark result page.
Benchmark differences below 5% might be due to CI noise.

Benchmark diff v0.7.0 vs. main

Parametrized benchmark signatures:

BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)

All benchmarks:

       before           after         ratio
     [9adf4a49]       [7e0285a7]
     <v0.7.0>                   
           failed           failed      n/a  BenchmarkOptimize.time_optimize(False, False, False)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(False, False, True)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(False, True, False)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(False, True, True)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(True, False, False)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(True, False, True)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(True, True, False)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(True, True, True)
             219M             219M     1.00  IntegrationTwoDatasets.peakmem_optimize
       1.02±0.01s       1.03±0.03s     1.01  IntegrationTwoDatasets.time_optimize

Benchmark diff main vs. PR

Parametrized benchmark signatures:

BenchmarkOptimize.time_optimize(index_dependent, grouped, weight)

All benchmarks:

       before           after         ratio
     [7e0285a7]       [7fa71983]
           failed           failed      n/a  BenchmarkOptimize.time_optimize(False, False, False)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(False, False, True)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(False, True, False)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(False, True, True)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(True, False, False)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(True, False, True)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(True, True, False)
           failed           failed      n/a  BenchmarkOptimize.time_optimize(True, True, True)
             219M             220M     1.01  IntegrationTwoDatasets.peakmem_optimize
       1.03±0.03s         964±50ms     0.93  IntegrationTwoDatasets.time_optimize

@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7e0285a) 88.3% compared to head (7fa7198) 88.3%.

Additional details and impacted files
@@          Coverage Diff           @@
##            main   #1276    +/-   ##
======================================
  Coverage   88.3%   88.3%            
======================================
  Files        107     107            
  Lines       5122    5122            
  Branches     847     960   +113     
======================================
  Hits        4525    4525            
  Misses       479     479            
  Partials     118     118            

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@s-weigand
Copy link
Member Author

Just trying out numba 0.57.0 on py311 and comparing results

@sonarcloud
Copy link

sonarcloud bot commented May 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@s-weigand s-weigand changed the title 🧪 Test numba 0.57.0rc1 🧪 Test numba 0.57.0 result comparison May 21, 2023
@s-weigand
Copy link
Member Author

This PR served its purpose by showing that we get the same results on python 3.11 with numba 0.57.0 and we did before.

@s-weigand s-weigand closed this May 21, 2023
@s-weigand s-weigand deleted the test-numba-0.57.0rc1 branch May 21, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant