Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PMFT Bin Orders #201

Closed
bdice opened this issue Jan 18, 2019 · 3 comments
Closed

PMFT Bin Orders #201

bdice opened this issue Jan 18, 2019 · 3 comments
Labels
enhancement New feature or request
Milestone
v2.0 beta

Comments

@bdice
Copy link
Member

bdice commented Jan 18, 2019 •
edited

The structure for PMFT's return arrays should be the same as its constructor. That is, XY, XYT, XYZ, R12. The underlying problem is that indexers are backwards.
@bdice bdice added minor enhancement New feature or request and removed minor labels Jan 23, 2019
vyasr added a commit that referenced this issue Jan 27, 2019
@vyasr
Merged in getters_to_properties (pull request #201)
ad7db6a 
Getters to properties

Approved-by: Bradley Dice <bdice@bradleydice.com>
Approved-by: Vyas Ramasubramani <vramasub@umich.edu>
@bdice bdice added this to the 2.0 milestone Feb 9, 2019
@vyasr
Copy link
Collaborator

vyasr commented Jun 10, 2019

Part of #179

@bdice
Copy link
Member Author

bdice commented Aug 27, 2019

This will be done when we switch PMFT to ManagedArray.

@vyasr vyasr mentioned this issue Sep 4, 2019
Merged
9 tasks
@vyasr
Copy link
Collaborator

vyasr commented Sep 19, 2019

Resolved by #425

@vyasr vyasr closed this as completed Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.0 beta
Development

No branches or pull requests
2 participants
@vyasr @bdice