-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color Voronoi Diagrams by Area #1012
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommy-waltmann
requested review from
yeinlim
and removed request for
a team
September 22, 2022 18:53
for more information, see https://pre-commit.ci
NOTE: The changes in this PR will require an update to the examples repository. |
b-butler
requested changes
Oct 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments to address.
Co-authored-by: Brandon Butler <butlerbr@umich.edu>
b-butler
approved these changes
Nov 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This option adds the ability to color voronoi plots by the area of the Voronoi polytopes. It involves an API change from the option
color_by_sides=True/False
tocolor_by='sides'/''area'/None
.Motivation and Context
Resolves: #991
How Has This Been Tested?
I have tested this locally with a variety of arguments and input values. See screenshots section below.
Screenshots
With
voro.plot()
With
voro.plot(color_by='sides')
With
voro.plot(color_by='area')
Types of changes
Checklist: