Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove codecov #1097

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Remove codecov #1097

merged 1 commit into from
Apr 17, 2023

Conversation

tommy-waltmann
Copy link
Collaborator

Description

This PR removes codecov from freud's requirements files.

Motivation and Context

The codecov package no longer exists on PyPI: https://about.codecov.io/blog/message-regarding-the-pypi-package/

freud doesn't use codecov to do anything anymore, so the requirement itself is vestigial.

I first noticed this on #1096 when CI failed for unknown reasons.

How Has This Been Tested?

If CI tests pass, we are good to go.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds or improves functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation improvement (updates to user guides, docstrings, or developer docs)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have updated the documentation (if relevant).
  • I have added tests that cover my changes (if relevant).
  • All new and existing tests passed.
  • I have updated the credits.
  • I have updated the Changelog.

@tommy-waltmann tommy-waltmann requested a review from a team as a code owner April 13, 2023 20:47
@tommy-waltmann tommy-waltmann requested review from klywang and removed request for a team April 13, 2023 20:47
@DomFijan DomFijan mentioned this pull request Apr 14, 2023
11 tasks
@tommy-waltmann tommy-waltmann merged commit fcdd0bc into master Apr 17, 2023
22 checks passed
@tommy-waltmann tommy-waltmann deleted the fix/remove-codecov branch April 17, 2023 18:11
@tommy-waltmann tommy-waltmann added this to the v2.13.0 milestone Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants