Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 3.6 #1099

Merged
merged 7 commits into from May 1, 2023
Merged

Drop python 3.6 #1099

merged 7 commits into from May 1, 2023

Conversation

tommy-waltmann
Copy link
Collaborator

Description

This PR drops support for python 3.6.

Motivation and Context

scikit-build dropped support for python 3.6 on its 0.17.0 release, so we will necessarily make this change as well.

How Has This Been Tested?

If unit tests and build wheels pass, we will be good to go.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds or improves functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation improvement (updates to user guides, docstrings, or developer docs)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have updated the documentation (if relevant).
  • I have added tests that cover my changes (if relevant).
  • All new and existing tests passed.
  • I have updated the credits.
  • I have updated the Changelog.

@tommy-waltmann tommy-waltmann added this to the v2.13.0 milestone Apr 26, 2023
@tommy-waltmann
Copy link
Collaborator Author

Combining #1098 with this PR. scikit-build stopped supporting python 3.6 so pinning to version 0.17.1 and dropping python 3.6 support will need to be addressed at the same time.

@tommy-waltmann tommy-waltmann mentioned this pull request Apr 27, 2023
11 tasks
@tommy-waltmann tommy-waltmann marked this pull request as ready for review April 27, 2023 17:41
@tommy-waltmann tommy-waltmann requested review from a team as code owners April 27, 2023 17:41
@tommy-waltmann tommy-waltmann requested review from b-butler and removed request for a team April 27, 2023 17:41
@tommy-waltmann tommy-waltmann merged commit 577da5c into master May 1, 2023
30 checks passed
@tommy-waltmann tommy-waltmann deleted the fix/update-python-support branch May 1, 2023 21:03
@joaander joaander mentioned this pull request May 8, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants