Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Translational OP #1227

Merged
merged 6 commits into from
Mar 1, 2024
Merged

Remove Translational OP #1227

merged 6 commits into from
Mar 1, 2024

Conversation

tommy-waltmann
Copy link
Collaborator

Description

This PR removes the translational order parameter, users should use Hexatic instead.

Motivation and Context

This class was deprecated sometime in 2020, but no corresponding issue to remove it was ever created. It should have been removed with the version 3.0.0 release.

How Has This Been Tested?

No new tests are necessary.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds or improves functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation improvement (updates to user guides, docstrings, or developer docs)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have updated the documentation (if relevant).
  • I have added tests that cover my changes (if relevant).
  • All new and existing tests passed.
  • I have updated the credits.
  • I have updated the Changelog.

@tommy-waltmann tommy-waltmann requested a review from a team as a code owner February 29, 2024 22:45
@tommy-waltmann tommy-waltmann requested review from b-butler and removed request for a team February 29, 2024 22:45
ChangeLog.md Outdated Show resolved Hide resolved
@tommy-waltmann tommy-waltmann merged commit 403eb9e into main Mar 1, 2024
15 checks passed
@tommy-waltmann tommy-waltmann deleted the remove-translational branch March 1, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants