Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/repr png more #318

Merged
merged 17 commits into from Jun 27, 2019
Merged

Feature/repr png more #318

merged 17 commits into from Jun 27, 2019

Conversation

jinsoo960
Copy link
Contributor

@jinsoo960 jinsoo960 commented Jun 19, 2019

Description

_repr_png_() and plot() have been added for GaussianDensity when 2D and LocalQl, LocalQlNear, LocalWl, and LocalWlNear.
Also, an issue of getting additional empty plot when using PMFTXY2D in Jupyter Lab has been fixed.

Motivation and Context

Resolves #314.

How Has This Been Tested?

Tests have been added and the images are available as screenshots.

Screenshots (if appropriate):

Screenshots in #314.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds or improves functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the Changelog.

@jinsoo960 jinsoo960 added the enhancement New feature or request label Jun 19, 2019
@jinsoo960 jinsoo960 self-assigned this Jun 19, 2019
Copy link
Member

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Sorry, I started reviewing this before it was marked as "ready for review" - my mistake.) Let's install matplotlib on CircleCI so that it can try to render the plots, just toss it into this PR. It will make our tests run more of the real code paths that we expect.

freud/order.pyx Outdated Show resolved Hide resolved
freud/plot.py Outdated Show resolved Hide resolved
freud/plot.py Show resolved Hide resolved
freud/plot.py Outdated Show resolved Hide resolved
freud/plot.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@d6184e9). Click here to learn what that means.
The diff coverage is 89.47%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #318   +/-   ##
=======================================
  Coverage          ?    94%           
=======================================
  Files             ?     16           
  Lines             ?   3301           
  Branches          ?     19           
=======================================
  Hits              ?   3103           
  Misses            ?    186           
  Partials          ?     12
Impacted Files Coverage Δ
freud/voronoi.pyx 95.75% <ø> (ø)
freud/pmft.pyx 98.72% <ø> (ø)
freud/environment.pyx 88.05% <ø> (ø)
freud/msd.pyx 75.7% <ø> (ø)
freud/cluster.pyx 94.16% <ø> (ø)
freud/common.pyx 95.89% <100%> (ø)
freud/density.pyx 97.06% <100%> (ø)
freud/plot.py 80.88% <79.48%> (ø)
freud/order.pyx 97.18% <93.1%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6184e9...16722e9. Read the comment docs.

@jinsoo960 jinsoo960 marked this pull request as ready for review June 19, 2019 23:09
@jinsoo960 jinsoo960 requested a review from a team as a code owner June 19, 2019 23:09
Copy link
Member

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested comments below.

freud/order.pyx Outdated Show resolved Hide resolved
freud/plot.py Outdated Show resolved Hide resolved
freud/plot.py Outdated Show resolved Hide resolved
freud/plot.py Show resolved Hide resolved
freud/plot.py Outdated Show resolved Hide resolved
freud/plot.py Outdated Show resolved Hide resolved
Copy link
Member

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggested changes below. Thanks!

freud/order.pyx Outdated Show resolved Hide resolved
freud/plot.py Outdated Show resolved Hide resolved
freud/plot.py Outdated Show resolved Hide resolved
freud/plot.py Show resolved Hide resolved
freud/plot.py Outdated Show resolved Hide resolved
@bdice bdice self-requested a review June 27, 2019 20:40
@bdice bdice merged commit 2ec61a5 into master Jun 27, 2019
@vyasr vyasr deleted the feature/repr_png_more branch July 7, 2019 19:49
@bdice bdice mentioned this pull request Nov 4, 2021
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more plottable analyses
2 participants