New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/repr png more #318
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Sorry, I started reviewing this before it was marked as "ready for review" - my mistake.) Let's install matplotlib
on CircleCI so that it can try to render the plots, just toss it into this PR. It will make our tests run more of the real code paths that we expect.
Codecov Report
@@ Coverage Diff @@
## master #318 +/- ##
=======================================
Coverage ? 94%
=======================================
Files ? 16
Lines ? 3301
Branches ? 19
=======================================
Hits ? 3103
Misses ? 186
Partials ? 12
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested comments below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggested changes below. Thanks!
…/freud into feature/repr_png_more
Description
_repr_png_()
andplot()
have been added forGaussianDensity
when 2D andLocalQl
,LocalQlNear
,LocalWl
, andLocalWlNear
.Also, an issue of getting additional empty plot when using
PMFTXY2D
in Jupyter Lab has been fixed.Motivation and Context
Resolves #314.
How Has This Been Tested?
Tests have been added and the images are available as screenshots.
Screenshots (if appropriate):
Screenshots in #314.
Types of changes
Checklist: